Make StandardComponentId constructor public#7763
Open
brunobat wants to merge 1 commit intoopen-telemetry:mainfrom
Open
Make StandardComponentId constructor public#7763brunobat wants to merge 1 commit intoopen-telemetry:mainfrom
brunobat wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7763 +/- ##
=========================================
Coverage 90.18% 90.19%
- Complexity 7196 7197 +1
=========================================
Files 814 814
Lines 21722 21722
Branches 2125 2125
=========================================
+ Hits 19590 19592 +2
+ Misses 1465 1464 -1
+ Partials 667 666 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Why? |
Contributor
Author
|
It's more obvious that having to use the parent class to create its objects: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents the instantiation of Senders outside of the SDK.
Related with #6718